RFR: 8349105: Pagination: exception initializing in a background thread [v5]
Kevin Rushforth
kcr at openjdk.org
Fri Feb 14 18:21:19 UTC 2025
On Tue, 11 Feb 2025 23:33:42 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> ## Root Cause
>> Animation gets started in a background thread, which causes the animation handler to run in the FX application thread, thus creating simultaneous access to the control's fields (list of children in this case).
>>
>> ## Solution
>> Postpone the animation unless running in the FX application thread. There is no functional difference if the component is created/used in the FX application thread.
>
> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
>
> - Merge branch '8349756.pagination.leak' into 8349105.thread.safety.pagination
> - back to constructor
> - memory leak
> - remove gc
> - slow down gc
> - gc
> - Merge branch 'master' into 8349105.thread.safety.pagination
> - postpone animation
> For testing purposes, merged this PR with the memory leak fix #1705 . Once the latter is integrated, unrelated changes will disappear.
Can you merge master so this will be realized?
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1698#issuecomment-2659987368
More information about the openjfx-dev
mailing list