RFR: 8349105: Pagination: exception initializing in a background thread [v6]
Michael Strauß
mstrauss at openjdk.org
Fri Feb 14 21:50:19 UTC 2025
On Fri, 14 Feb 2025 18:26:31 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> ## Root Cause
>> Animation gets started in a background thread, which causes the animation handler to run in the FX application thread, thus creating simultaneous access to the control's fields (list of children in this case).
>>
>> ## Solution
>> Postpone the animation unless running in the FX application thread. There is no functional difference if the component is created/used in the FX application thread.
>
> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains nine commits:
>
> - Merge remote-tracking branch 'origin/master' into 8349105.thread.safety.pagination
> - Merge branch '8349756.pagination.leak' into 8349105.thread.safety.pagination
> - back to constructor
> - memory leak
> - remove gc
> - slow down gc
> - gc
> - Merge branch 'master' into 8349105.thread.safety.pagination
> - postpone animation
Looks good.
-------------
Marked as reviewed by mstrauss (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/1698#pullrequestreview-2618866520
More information about the openjfx-dev
mailing list