RFR: 8313424: JavaFX controls in the title bar [v50]
Andy Goryachev
angorya at openjdk.org
Tue Feb 18 19:27:38 UTC 2025
On Sat, 15 Feb 2025 01:19:04 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:
>> Implementation of [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09) and `EXTENDED_UTILITY` stage style.
>
> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>
> minify button glyphs
modules/javafx.graphics/src/main/resources/com/sun/glass/ui/gtk/WindowDecorationGnome.css line 126:
> 124:
> 125: .close-button > .glyph {
> 126: -fx-shape: "m 8.1465,8.1465 a 0.5,0.5 0 0 0 0,0.707 L 11.293,12 8.1465,15.1465 a 0.5,0.5 0 0 0 0,0.707 0.5,0.5 0 0 0 0.707,0 L 12,12.707 l 3.1465,3.1465 a 0.5,0.5 0 0 0 0.707,0 0.5,0.5 0 0 0 0,-0.707 L 12.707,12 15.8535,8.8535 a 0.5,0.5 0 0 0 0,-0.707 0.5,0.5 0 0 0 -0.707,0 L 12,11.293 8.8535,8.1465 a 0.5,0.5 0 0 0 -0.707,0 z";
Not sure I like the idea of using chatGPT.
The changes look inconsistent - some are rounded to 3 places after the decimal, some to 4 (3 should be sufficient, I think even 2 will suffice)
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1960264009
More information about the openjfx-dev
mailing list