RFR: 8313424: JavaFX controls in the title bar [v49]

Andy Goryachev angorya at openjdk.org
Tue Feb 18 19:59:05 UTC 2025


On Tue, 18 Feb 2025 19:33:48 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> Let me clarify:
>> I think the css properties must be listed in `cssref.html` as the component can be styled via CSS.  I don't see the `cssref.html` file modified in this PR.
>
> `cssref.html` is the normative reference for the JavaFX CSS API. `HeaderButtonOverlay` is not API, it can't be styled by developers, it's completely inaccessible, and therefore must not be specified anywhere.
> 
> It's even unspecified whether `HeaderButtonOverlay` is used _at all_. For example, on macOS it's never used.

`cssref.html` **_IS_** a part of normative reference for JavaFX API.

And my comment is not limited to a single class, it applies to every new CSS property added here.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1960500377


More information about the openjfx-dev mailing list