RFR: 8313424: JavaFX controls in the title bar [v49]

[Andy Goryachev]

On Tue, 18 Feb 2025 20:04:37 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> The word "inset" confused me.  Could you use some other word here, if it is referring to a dimension?  Like maybe explain where exactly these are used?
>
> Are we talking about the specification of the system-reserved insets in `HeaderBar`? Or do you suggest to link from `HeaderButtonMetrics` to `HeaderBar`?
> 
> 
>     /**
>      * Describes the size of the left system-reserved inset, which is an area reserved for the iconify, maximize,
>      * and close window buttons. If there are no window buttons on the left side of the window, the returned area
>      * is an empty {@code Dimension2D}.
>      * <p>
>      * Note that the left system inset refers to the left side of the window, independent of layout orientation.
>      */
>     private final ReadOnlyObjectWrapper<Dimension2D> leftSystemInset =

a link would be nice, yes (for javafx developers) :-)

it could be just me - the word "inset" confused me ("insets" -> `Insets`, "inset" -> `Dimension2D`), but I guess it does describe the concept correctly.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1960533763