RFR: 8313424: JavaFX controls in the title bar [v50]
Andy Goryachev
angorya at openjdk.org
Tue Feb 18 20:24:11 UTC 2025
On Sat, 15 Feb 2025 01:19:04 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:
>> Implementation of [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09) and `EXTENDED_UTILITY` stage style.
>
> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>
> minify button glyphs
modules/javafx.graphics/src/main/java/javafx/scene/layout/HeaderBar.java line 341:
> 339: * @param trailing the trailing node
> 340: */
> 341: public HeaderBar(Node leading, Node center, Node trailing) {
here you refer to "leading" and "trailing", but the system insets are "left" and "right", why is that?
When the platform goes RTL, don't the buttons flip as well? Should the system insets be referred to as leading/trailing?
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1960536558
More information about the openjfx-dev
mailing list