RFR: 8349750: [TestBug] NodeInitializationStressTest: remaining Nodes [v2]
Kevin Rushforth
kcr at openjdk.org
Tue Feb 25 21:41:57 UTC 2025
On Tue, 25 Feb 2025 20:20:27 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> ## Added Missing Controls
>>
>> ButtonBar
>> ProgressIndicator
>> Separator
>> Slider,
>>
>> ## Added Node Classes
>>
>> AnchorPane
>> AmbientLight
>> Arc
>> BorderPane
>> Box
>> Circle
>> CubicCurve
>> Cylinder
>> DialogPane
>> DirectionalLight
>> Ellipse
>> FlowPane
>> GridPane
>> Group
>> HBox
>> ImageView
>> Line
>> MediaView
>> MeshView
>> Pane
>> ParallelCamera
>> Path
>> PerspectiveCamera
>> PointLight
>> Polygon
>> Polyline
>> QuadCurve
>> Rectangle
>> Region
>> Sphere
>> StackPane
>> SVGPath
>> TilePane
>> VBox
>>
>>
>> ## Miscellaneous
>>
>> - minor improvements
>> - remove tests that execute show() in non-fx threads per [JDK-8350048](https://bugs.openjdk.org/browse/JDK-8350048)
>>
>>
>>
>> ## Not Included Due to Threading Limitations
>>
>> HTMLEditor
>> MenuBar
>> SwingNode
>> WebView
>>
>> ## Note to the Reviewers
>>
>> To avoid merge conflicts, the preferred order of integrations:
>>
>> #1697
>> #1713
>> #1717
>
> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits:
>
> - review comments
> - Merge remote-tracking branch 'origin/master' into 8349750.stress.2
> - cleanup
> - images
> - Merge remote-tracking branch 'origin/master' into 8349750.stress.2
> - media
> - Merge remote-tracking branch 'origin/master' into 8349750.stress.2
> - 3d
> - shapes
> - show()
> - ... and 4 more: https://git.openjdk.org/jfx/compare/f38ab33b...a8b892ab
LGTM. I think a single reviewer should be sufficient for this test fix.
-------------
Marked as reviewed by kcr (Lead).
PR Review: https://git.openjdk.org/jfx/pull/1713#pullrequestreview-2642489943
More information about the openjfx-dev
mailing list