RFR: 8327478: Add System test to verify TextSelection issue for webkit-617.1

Fri Feb 28 21:43:58 UTC 2025

On Fri, 21 Feb 2025 06:59:52 GMT, Gopal Pattnaik <duke at openjdk.org> wrote:

> There was no test included with the fix for [JDK-8326989](https://bugs.openjdk.org/browse/JDK-8326989),
> 
> Hence we are adding a system test now.
> 
> Test is written as 
> 1. Load html content in web view.
> 2. pick the color of mouse pointer.
> 3. Perform double click.
> 4. pick the color again.
>> expected bahaviour: colour picked in step 2 and 4 should not match.
> 
> Verification:
> The test passes with latest webkit source
> Also verified that test fails when the fix for [JDK-8326989](https://bugs.openjdk.org/browse/JDK-8326989) is reverted.

tests/system/src/test/java/test/robot/javafx/web/TextSelectionTest.java line 45:

> 43: import test.util.Util;
> 44: 
> 45: public class TextSelectionTest {

I wonder if we could extend RobotTestBase base class to simplify the code?

tests/system/src/test/java/test/robot/javafx/web/TextSelectionTest.java line 47:

> 45: public class TextSelectionTest {
> 46: 
> 47:     private static final String html = "<html>" +

we could use new java text block here

private static final String html =
    """
    <html>
    <head></head>
    <body>&nbsp&nbsp&nbsp&nbsp some text</body>
    </html>
    """;

tests/system/src/test/java/test/robot/javafx/web/TextSelectionTest.java line 97:

> 95: 
> 96:         int x = (int)(scene.getWindow().getX() + scene.getX() + 22);
> 97:         int y = (int)(scene.getWindow().getY() + scene.getY() + 15);

can these offsets (22, 15) be measured instead of hard-coded?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1719#discussion_r1976035941
PR Review Comment: https://git.openjdk.org/jfx/pull/1719#discussion_r1976034756
PR Review Comment: https://git.openjdk.org/jfx/pull/1719#discussion_r1976037222