Integrated: 8342233: Regression: TextInputControl selection is backwards in RTL mode

Andy Goryachev angorya at openjdk.org
Mon Jan 6 16:50:47 UTC 2025


On Fri, 25 Oct 2024 22:00:37 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

> A fix for [JDK-8319844](https://bugs.openjdk.org/browse/JDK-8319844) Text/TextFlow.hitTest() introduced a regression in the `TextArea`/`TextField`/`PasswordField` in the RTL mode.
> 
> The fix is to flip the x coordinates when needed in the `TextAreaSkin`/`TextFieldSkin`.
> 
> The RTL node orientation also breaks navigation using keyboard arrow keys, but that's a different issue: [JDK-8296266](https://bugs.openjdk.org/browse/JDK-8296266).
> 
> ---
> 
> I tried to devise a headful test, but it is currently blocked by [JDK-8189167](https://bugs.openjdk.org/browse/JDK-8189167)
> 
> The fix can be tested manually using the Monkey Tester, with the headful test to be added probably as a part of [JDK-8326869](https://bugs.openjdk.org/browse/JDK-8326869) .

This pull request has now been integrated.

Changeset: 98916fee
Author:    Andy Goryachev <angorya at openjdk.org>
URL:       https://git.openjdk.org/jfx/commit/98916feed6a9ff4da63ff778fdb0336d43ffaca8
Stats:     610 lines in 8 files changed: 559 ins; 23 del; 28 mod

8342233: Regression: TextInputControl selection is backwards in RTL mode

Reviewed-by: kizune, lkostyra

-------------

PR: https://git.openjdk.org/jfx/pull/1609


More information about the openjfx-dev mailing list