RFR: 8345188: Support tree-structural pseudo-classes [v8]

[John Hendrikx]

On Wed, 8 Jan 2025 19:52:21 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   move pseudo-class changes to end of onChanged
>
> modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html line 2059:
> 
>> 2057:           <th class="propertyname" scope="row">nth-child()</th>
>> 2058:           <td>applies when the node is the n-th child in its <code>Parent</code> container
>> 2059:               (the only acceptable arguments are "even" and "odd")</td>
> 
> should we also specify that the numbering is 1-based?
> i.e. the child at index 0 is the first (1st) and therefore `ODD`?

While I was reviewing, I had to look that up so I could check if the code was doing the correct thing. CSS indeed considers the first child as having index 1, even though it will be index 0 in the list returned by `getChildren`.  It may be worth pointing that out explicitly.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1652#discussion_r1907925276