RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v33]
Lukasz Kostyra
lkostyra at openjdk.org
Thu Jan 16 12:53:03 UTC 2025
On Sun, 15 Dec 2024 22:11:30 GMT, Thiago Milczarek Sayao <tsayao at openjdk.org> wrote:
>> This replaces obsolete XIM and uses gtk api for IME.
>> Gtk uses [ibus](https://github.com/ibus/ibus)
>>
>> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative positioning on `InputMethodRequest`.
>>
>> [Screencast from 17-09-2023 21:59:04.webm](https://github.com/openjdk/jfx/assets/30704286/6c398e39-55a3-4420-86a2-beff07b549d3)
>
> Thiago Milczarek Sayao has updated the pull request incrementally with three additional commits since the last revision:
>
> - Better solution for fcitx
> - Revert "Fixes for fcitx"
>
> This reverts commit d8b38ea8f1379f9783d9186e462b0652ae7fd98b.
> - Revert "Fixes for fcitx"
>
> This reverts commit 6cd1d32a51149df2cbe36f0b348a464173422201.
Holiday season went in the way of wrapping this up last year, but I finally got a chance to come back to it and finish the review.
Code-review-wise looks good. I also run the tests on my Ubuntu 24.04 and did not notice any abnormalities.
@kevinrushforth also wanted to take a look at this after me.
-------------
Marked as reviewed by lkostyra (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/1080#pullrequestreview-2555932036
More information about the openjfx-dev
mailing list