RFR: 8185887: TableRowSkinBase fails to correctly virtualize cells in horizontal direction [v4]
Andy Goryachev
angorya at openjdk.org
Thu Jan 16 15:49:45 UTC 2025
On Thu, 16 Jan 2025 12:11:37 GMT, Marius Hanl <mhanl at openjdk.org> wrote:
>> Maybe the name `pulse` in the test you point out is misleading, since it actually calls `flow.layout()`, and two layout passes is not the same as two pulses.
>
> That is right, but the `pulse` call will call `layout`, which will call `layoutChildren` (when needed). I could also just call `layout` directly, but want to keep it the same way as the actual Application would behave.
Relying on two pulses may cause flicker (I had a similar issue with the RichTextArea).
The solution is to re-compute the layout in layoutChildren() when needed (i.e. when scroll bar status changes).
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1644#discussion_r1918790333
More information about the openjfx-dev
mailing list