RFR: 8170720: VetoableListDecorator: Indexes to remove are not aggregated

Kevin Rushforth kcr at openjdk.org
Fri Jan 24 21:40:53 UTC 2025


On Tue, 14 Jan 2025 01:56:10 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

> `VetoableListDecorator` does not correctly report removed indices. Instead of reporting ranges like `[0, 3)`, it always reports a pairwise list of single removals like `[0, 1, 1, 2, 2, 3)`.
> 
> The reason is a off-by-one error, and the fix is simple.

Looks good. I confirm that the added tests fail without and pass with the fix.

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/1675#pullrequestreview-2573623814


More information about the openjfx-dev mailing list