RFR: 8299753: Tree/TableView: Column Resizing With Fractional Scale [v6]

Andy Goryachev angorya at openjdk.org
Mon Jan 27 15:44:59 UTC 2025


On Sat, 25 Jan 2025 00:37:28 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> we will violate the max constraint if we snap to a larger value.
>> 
>> so for the max constraint, we should `snapInnerSpace()` which calls the private (?)  `Region.snapPortionX()`.
>
>> we will violate the max constraint if we snap to a larger value.
> 
> Well, it's inherently an over-constrained problem. Conceptually, though, this does not violate the constraint. When snap-to-pixel is enabled, all values, including min and max values are snapped to a pixel that can be almost 1 pixel larger or smaller than it's given value. Within that tolerance, we are honoring the min  and max values.
> 
> It isn't required that we always ceil the min value and floor the max value (not to mention that doing that is what causes the odd min > max).
> 
> So I don't buy this argument. Is there some other reason to do it?

no other reason.  are you suggesting to simply `round()`?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1156#discussion_r1930740267


More information about the openjfx-dev mailing list