RFR: 8345261: Refactor the Dimension2D classes [v2]

Nir Lisker nlisker at openjdk.org
Mon Jan 27 16:59:05 UTC 2025


On Mon, 27 Jan 2025 16:36:28 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address review comments
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/geom/Dimension2Df.java line 34:
> 
>> 32:  * @see javafx.geometry.Dimension2D Dimension2D - doubles
>> 33:  */
>> 34: public record Dimension2Df(float width, float height) {}
> 
> is this class really needed?
> 
> Looks like it's only referenced from `Arc2D::setArc()` and `RectanglularShape::setFrame()`, as far as I can tell these two methods are never called.
> 
> Should all three be removed?

I'm not familiar with these methods, but I did wonder why we need extra implementations in the initial comment.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1653#discussion_r1930861843


More information about the openjfx-dev mailing list