RFR: 8345261: Refactor the Dimension2D classes [v2]

Nir Lisker nlisker at openjdk.org
Mon Jan 27 17:40:54 UTC 2025


On Mon, 27 Jan 2025 17:28:14 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> I'm not familiar with these methods, but I did wonder why we need extra implementations in the initial comment.
>
> looks like dead code left over from the original implementation.
> 
> I removed the class along with the two methods and jfx builds (**you need to merge the latest master though**) and runs (i.e. shows arcs and rectangles) just fine.  Eclipse IDE also has no issues.  I think we can remove these.

I don't mind removing them in this PR if others agree.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1653#discussion_r1930941813


More information about the openjfx-dev mailing list