RFR: 8324941: POC for Headless platform for JavaFX [v4]
Johan Vos
jvos at openjdk.org
Mon Jul 7 09:22:45 UTC 2025
On Fri, 27 Jun 2025 20:00:48 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> Johan Vos has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Process reviewer comments
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessWindow.java line 19:
>
>> 17:
>> 18: private static final AtomicInteger ptrCount = new AtomicInteger(0);
>> 19: private long ptr;
>
> since `ptr` is long, should `ptrCount` be `AtomicLong`?
it's more elegant indeed, so I changed it.
It's not really needed though, since contrary to native implementations, the pointer we return here is not a pointer to some memory, hence we don't need 64 bits. The method declaration for _createWindow requires a long though, so we need to return a long.
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessWindow.java line 316:
>
>> 314: int b = rgba & 0xFF;
>> 315:
>> 316: Color color = Color.color(
>
> could use `Color::rgb(int,int,int,double)`;
done
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1836#discussion_r2189466725
PR Review Comment: https://git.openjdk.org/jfx/pull/1836#discussion_r2189468946
More information about the openjfx-dev
mailing list