RFR: 8324941: POC for Headless platform for JavaFX [v7]
    Johan Vos 
    jvos at openjdk.org
       
    Mon Jul  7 17:56:06 UTC 2025
    
    
  
On Mon, 7 Jul 2025 17:15:12 GMT, Jose Pereda <jpereda at openjdk.org> wrote:
>> Johan Vos has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Process more reviewer comments
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessWindow.java line 296:
> 
>> 294:         int b = rgba & 0xFF;
>> 295: 
>> 296:         Color color = Color.rgb(r, g, b, a);
> 
> `Color::rgb` requires opacity between 0 and 1, therefore, you need:
> 
> 
> Color color = Color.rgb(r, g, b, a / 255.0);
> 
> Minor: you can inline the variable.
Good catch, thanks!
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1836#discussion_r2190726879
    
    
More information about the openjfx-dev
mailing list