RFR: 8357714: AudioClip.play crash on macOS when loading resource from jar [v3]
Johan Vos
jvos at openjdk.org
Thu Jul 10 07:45:26 UTC 2025
> After JDK-8287822 (https://bugs.openjdk.org/browse/JDK-8287822), mpeg file content is no longer played via GSTPlatform but via OSXPlatform.
> We need to correctly handle data in case the source is a file inside a jar, in which case CJavaInputStreamCallbacks is used.
>
> The 2 changes I made are:
> 1. Use ConnectionHolder instead of Locator for CJavaInputStreamCallbacks in case a jar resource is used.
> 2. In case of random access datasource, use readBlock instead of readNextBlock in AVMediaPlayer
Johan Vos has updated the pull request incrementally with one additional commit since the last revision:
Remove whitespace
-------------
Changes:
- all: https://git.openjdk.org/jfx/pull/1839/files
- new: https://git.openjdk.org/jfx/pull/1839/files/e99a8504..15ce1ee6
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jfx&pr=1839&range=02
- incr: https://webrevs.openjdk.org/?repo=jfx&pr=1839&range=01-02
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jfx/pull/1839.diff
Fetch: git fetch https://git.openjdk.org/jfx.git pull/1839/head:pull/1839
PR: https://git.openjdk.org/jfx/pull/1839
More information about the openjfx-dev
mailing list