RFR: 8271024: Implement macOS Metal Rendering Pipeline [v6]
Ambarish Rapte
arapte at openjdk.org
Tue Jul 15 05:41:36 UTC 2025
On Tue, 8 Jul 2025 10:50:32 GMT, Lukasz Kostyra <lkostyra at openjdk.org> wrote:
>> Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision:
>>
>> add @Override
>
> modules/javafx.graphics/src/main/native-prism-mtl/MetalContext.m line 1437:
>
>> 1435: [pCtx endCurrentRenderEncoder];
>> 1436:
>> 1437: id<MTLCommandBuffer> commandBuffer = [pCtx getCurrentCommandBuffer];
>
> I think most of this function should become a `MetalContext` method that would be called here. That way we separate the Metal-related implementation from JNI entry points and it follows the pattern of other JNI entry points in this file.
Thanks for noticing this. As you pointed out there were a few more similar methods that needed change.
All such methods are now updated. Along with there are a few minor changes like, removing methods and method parameters that are not used/can be avoided.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1824#discussion_r2206439310
More information about the openjfx-dev
mailing list