RFR: 8271024: Implement macOS Metal Rendering Pipeline [v8]

Ambarish Rapte arapte at openjdk.org
Fri Jul 18 18:05:49 UTC 2025


On Wed, 16 Jul 2025 19:44:29 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> modules/javafx.graphics/src/main/java/com/sun/prism/mtl/MTLShader.java line 57:
>> 
>>> 55:             shaderMap.put(fragmentFunctionName, this);
>>> 56:         } else {
>>> 57:             throw new AssertionError("Failed to create Shader");
>> 
>> is `AssertionError` the right type here?
>
> Good catch. I think this should throw a `RuntimeException` of some sort.

We throw an InternalError from MTLResourceFactory.createStockShader() if shader creation fails. For matching changed here to use InternalError. If not Ok, then I shall change it. please check.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1824#discussion_r2216606058


More information about the openjfx-dev mailing list