RFR: 8362873: Regression in BorderPane after JDK-8350149
    Andy Goryachev 
    angorya at openjdk.org
       
    Tue Jul 22 16:14:01 UTC 2025
    
    
  
On Tue, 22 Jul 2025 00:05:35 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:
> This PR fixes a regression introduced in #1723
> 
> It reverts the changes made in the BorderPaneTest with new comments explaining why the values are what they are.  It only fixes the regression that was introduced, but it can be said that the calculation is probably also incorrect when a vertical biased control is encountered (the `getAreaWidth` and `getAreaHeight` in `BorderPane` were, and are still not using the same way to calculate their respective sizes).  See the ticket for more details and screenshots.
> 
> Let me know if I should only address the regression introduced, or also include the fix for the bias calculation for vertical bias controls.
Marked as reviewed by angorya (Reviewer).
This PR fixes the vertical layout case (`verticalLayout = true;`).
Do we have a ticket for the incorrect computation for the horizontal layout?  If not, could you please create a follow-up one?
<img width="861" height="816" alt="Screenshot 2025-07-22 at 09 08 16" src="https://github.com/user-attachments/assets/a7604eae-65c3-46cd-8d02-06b9cf531e08" />
-------------
PR Review: https://git.openjdk.org/jfx/pull/1850#pullrequestreview-3043780478
PR Comment: https://git.openjdk.org/jfx/pull/1850#issuecomment-3103612681
    
    
More information about the openjfx-dev
mailing list