RFR: 8362873: Regression in BorderPane after JDK-8350149
Michael Strauß
mstrauss at openjdk.org
Tue Jul 22 16:27:01 UTC 2025
On Tue, 22 Jul 2025 00:05:35 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:
> This PR fixes a regression introduced in #1723
>
> It reverts the changes made in the BorderPaneTest with new comments explaining why the values are what they are. It only fixes the regression that was introduced, but it can be said that the calculation is probably also incorrect when a vertical biased control is encountered (the `getAreaWidth` and `getAreaHeight` in `BorderPane` were, and are still not using the same way to calculate their respective sizes). See the ticket for more details and screenshots.
>
> Let me know if I should only address the regression introduced, or also include the fix for the bias calculation for vertical bias controls.
The fix looks good.
-------------
Marked as reviewed by mstrauss (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/1850#pullrequestreview-3043825356
More information about the openjfx-dev
mailing list