RFR: 8271024: Implement macOS Metal Rendering Pipeline [v8]

[Ambarish Rapte]

On Wed, 16 Jul 2025 19:48:47 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> modules/javafx.graphics/src/main/java/com/sun/prism/es2/ES2SwapChain.java line 240:
>> 
>>> 238:     @Override
>>> 239:     public int getFboID() {
>>> 240:         return (int)nativeDestHandle;
>> 
>> this results in loss of information.  any possibility that it may backfire somehow, by mapping two different `nativeDestHandle`s to the same `int`?
>
> Good question. Given that the ES2 pipeline only ever uses an int value, it's _probably_ fine. But it's hard to prove without looking at the native code. At the very least, a comment explaining this would be good.

I shall add a comment, the value that nativeDestHandle stores is of type unsigned int. hence this type conversion is safe.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1824#discussion_r2223208172