RFR: 8359601: Fix window button states of an extended stage [v6]
Kevin Rushforth
kcr at openjdk.org
Thu Jul 24 22:20:02 UTC 2025
On Thu, 24 Jul 2025 21:59:35 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:
>> modules/javafx.graphics/src/main/native-glass/mac/GlassWindow.m line 1165:
>>
>>> 1163: {
>>> 1164: GlassWindow *window = getGlassWindow(env, jPtr);
>>> 1165: [window _setResizable:jResizable];
>>
>> I presume you removed the `performSelectorOnMainThread` because the calling method always calls this on the main thread?
>
> Yes, this is a call that always happens on the FX thread as a result of calling `javafx.stage.Window.show()`. This is verified just a few lines earlier with `GLASS_ASSERT_MAIN_JAVA_THREAD` (that's always been there, I didn't add it).
Also, the calling Java code does a thread check. So we're good.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1831#discussion_r2229693772
More information about the openjfx-dev
mailing list