RFR: 8271024: Implement macOS Metal Rendering Pipeline [v11]
Nir Lisker
nlisker at openjdk.org
Fri Jul 25 20:58:03 UTC 2025
On Fri, 25 Jul 2025 20:32:41 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> modules/javafx.graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/hw/MSLBackend.java line 216:
>>
>>> 214: // For every user defined function, pass reference to 4 samplers and
>>> 215: // reference to the uniforms struct.
>>> 216: if (!CoreSymbols.getFunctions().contains(getFuncName(e.getFunction().getName())) &&
>>
>> Eclipse kindly warns that `CoreSymbols.getFunctions()` is a collection of `Function`, but it's searched of a `String`. Perhaps `.getName()` shouldn't be called here?
>
> This means your Eclipse configuration differs from mine. Should we pull your configuration changes to this PR?
I commented on all the places where Eclipse gives a warning in this PR. Do you want me to upload the compiler settings? I think we discussed at some point the need to upload the formatter and other setting to the repo.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1824#discussion_r2231992174
More information about the openjfx-dev
mailing list