RFR: 8354943: [Linux] Simplify and update glass gtk backend: window sizing, positioning, and state management issues [v49]

[Thiago Milczarek Sayao]

On Wed, 23 Jul 2025 11:07:06 GMT, Lukasz Kostyra <lkostyra at openjdk.org> wrote:

>> Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 58 commits:
>> 
>>  - Remove repaint call (8351867 is fixed)
>>  - Merge branch 'master' into 8354943
>>  - Remove unused const
>>  - Remove wrong call to enter_fullscreen
>>  - Review changes
>>  - Use process_expose
>>  - Min / Max size improvements
>>  - Invalidate view size on new view
>>  - Re-allow fullscreen on child
>>  - Test fixes for mac + typo
>>  - ... and 48 more: https://git.openjdk.org/jfx/compare/0270847b...016ff681
>
> modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp line 1036:
> 
>> 1034: void WindowContext::notify_fullscreen(bool enter) {
>> 1035:     if (enter) {
>> 1036:         LOG("com_sun_glass_events_ViewEvent_FULLSCREEN_ENTER\n");
> 
> This could be simplified to
> 
> 
> LOG("com_sun_glass_events_ViewEvent_FULLSCREEN_%s\n", enter ? "ENTER" : "EXIT");
> mainEnv->CallVoidMethod(jview, jViewNotifyView, enter ? com_sun_glass_events_ViewEvent_FULLSCREEN_ENTER : com_sun_glass_events_ViewEvent_FULLSCREEN_EXIT);
> CHECK_JNI_EXCEPTION(mainEnv)

Done

> modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp line 1359:
> 
>> 1357: }
>> 1358: 
>> 1359: // This only works o Xorg
> 
> Minor: "works o" -> "works on"

Fixed

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1789#discussion_r2234027259
PR Review Comment: https://git.openjdk.org/jfx/pull/1789#discussion_r2234027224