RFR: 8364203: ignore native mac tests on headless
Kevin Rushforth
kcr at openjdk.org
Mon Jul 28 21:34:00 UTC 2025
On Mon, 28 Jul 2025 20:41:46 GMT, Johan Vos <jvos at openjdk.org> wrote:
> Add PlatformUtil.isHeadless() method.
> Use that in tests to conditionally skip tests.
>
> Fix JDK-8364203
This looks reasonable with one comment inline.
Also, as noted by Skara, I recommend to capitalize the first letter of the title (both JBS and PR) for consistency.
tests/system/src/test/java/test/com/sun/glass/ui/mac/MacPasteboardTest.java line 70:
> 68: @Test
> 69: public void testValidLocalImageURLMacPasteboard() throws Exception {
> 70: assumeTrue(PlatformUtil.isMac() && !PlatformUtil.isHeadless());
`setup` and `teardown` should probably be similarly qualified with "not headless".
-------------
PR Review: https://git.openjdk.org/jfx/pull/1859#pullrequestreview-3064631426
PR Review Comment: https://git.openjdk.org/jfx/pull/1859#discussion_r2237873525
More information about the openjfx-dev
mailing list