RFR: 8341286: TreeView: visual artifacts when setting new root with null value

Ziad El Midaoui zelmidaoui at openjdk.org
Mon Jul 28 22:27:29 UTC 2025


On Mon, 28 Jul 2025 18:49:34 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Fix for phantom disclosure nodes appearing when root is null
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeCellSkin.java line 363:
> 
>> 361:     private void updateDisclosureNode() {
>> 362: //        JDK-8341281 : Root TreeItem with null value breaks TreeTableView
>> 363: //        if (getSkinnable().isEmpty()) return;
> 
> I think you've got it!
> I can't reproduce the issue with your fix - both the reproducer and the monkey tester work correctly.
> 
> You don't need to keep the commented out code, please remove it.

Yes this is what caused the issue and the disclosure nodes to appear randomly
I will remove it

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1838#discussion_r2237960762


More information about the openjfx-dev mailing list