RFR: 8271024: Implement macOS Metal Rendering Pipeline [v11]
Ambarish Rapte
arapte at openjdk.org
Wed Jul 30 10:12:12 UTC 2025
On Fri, 25 Jul 2025 18:49:12 GMT, Nir Lisker <nlisker at openjdk.org> wrote:
>> Ambarish Rapte has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:
>>
>> - Merge branch 'master' into impl-metal
>> - add comment for ES2SwapChain.getFboID
>> - remove MTLLog
>> - andy review comments 1
>> - changes for running apps in eclipse
>> - review-update: jni method refactoring
>> - add @Override
>> - minor cleanup changes in glass
>> - Use appropriate layer for setting opacity
>> - Glass changes after Metal PR inputs
>> - ... and 2 more: https://git.openjdk.org/jfx/compare/17925b6e...1a9a0a41
>
> modules/javafx.graphics/src/main/java/com/sun/prism/mtl/MTLResourceFactory.java line 103:
>
>> 101: return createShader(pixelShaderName, samplers, params, maxTexCoordIndex,
>> 102: isPixcoordUsed, isPerVertexColorUsed);
>> 103: } catch (Exception e) {
>
> `e` is unused and can be `_` if this is correct (e.g., no `e.printStackTrace()`). Same in other places.
Added `e.printStackTrace()`.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1824#discussion_r2242158909
More information about the openjfx-dev
mailing list