RFR: 8364049: ToolBar shows overflow menu with fractional scale [v2]

[Andy Goryachev]

On Wed, 30 Jul 2025 18:06:29 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> Yes, but I wanted to do a very localized fix, to be included in jfx25.  There are many places where we should be more careful with snapping mentioned in description, and I suspect even more elsewhere.
>> 
>> I am still not sure what would be the best approach to address them all.  We could probably create an umbrella task and fix individual controls and containers (maybe even start with containers, in continuation of John's work with HBox and VBox).
>> 
>> I think this PR is still good, because a) it provides a fix for the specific issue and b) minimizes regression, but I agree with you that a comprehensive fix is needed.
>> 
>> What do you think?
>
> I understand that you want this to be a localized fix. I'm just proposing to change `getToolbarLength` instead, which is even less changed code than your change in `getOverflowNodeIndex`, and seems to be addressing the source of the incorrect length instead.

Upon closer inspection, your suggestion is better: even though the change would impact more code paths including the layout, the actual value produced gets fed into the same `getOverflowNodeIndex()` function.

Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1856#discussion_r2243592592