RFR: 8271024: Implement macOS Metal Rendering Pipeline [v11]

[Kevin Rushforth]

On Wed, 30 Jul 2025 19:10:57 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> I just looked at which .java files are not on the classpath and pulled those source folders in:
>> <img width="227" height="234" alt="image" src="https://github.com/user-attachments/assets/a81ef455-cc97-4b75-be96-cbd3de5bb266" />
>
> This issue is still unresolved: `CoreSymbols.getFunctions()` is a collection of `Function`, but it's searched for a `String` (.getName()).
> 
> The code in lines 216 and 238 needs to be fixed.
> 
> I suspect we are missing a unit test that exercises this functionality, because the code should never work.  How did it work?

Andy and Nir are right. I don't see how the following can do what you intend:


if (!CoreSymbols.getFunctions().contains(getFuncName(e.getFunction().getName())) &&


Since `CoreSymbols.getFunctions()` is a `Set<Function>` and `e.getFunction().getName()` is a `String`, the `contains` will always return false (meaning this term in the `if` expression is always true).

Can you check this?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1824#discussion_r2246510678