RFR: 8358454: Wrong <br> tags in cssref.html
Andy Goryachev
angorya at openjdk.org
Tue Jun 3 14:40:02 UTC 2025
On Tue, 3 Jun 2025 01:14:04 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:
> Some `<br>` tags in cssref.html are written as `<br/>` or `</br>`. It should be `<br>`, since it is a void element.
>
> A single reviewer is sufficient.
left minor comments, otherwise looks good.
modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html line 1682:
> 1680: <h3><a id="typeeasingfunction"><easing-function></a></h3>
> 1681: <p class="grammar">linear | <cubic-bezier-easing-function> | <step-easing-function> | <fx-easing-function></p>
> 1682: <p><strong>Linear</strong> <span class="grammar" style="font-size: smaller;">linear</span><br>
why is Linear looks like plain `linear` but Cubic Bézier Easing Functions has triangular brackets `<cubic-bezier-easing-function>`?
modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html line 1733:
> 1731: <td style="width: 120px; vertical-align: top"><span class="grammar">steps</span></td>
> 1732: <td>defines a step function with <a href="#typenumber" class="typelink"><integer></a> intervals
> 1733: and an optional <span class="grammar"><step-position></span>;<br>if omitted,
possible future enhancement: add thin grid lines to the tables, similar to other tables.
-------------
PR Review: https://git.openjdk.org/jfx/pull/1820#pullrequestreview-2892762843
PR Review Comment: https://git.openjdk.org/jfx/pull/1820#discussion_r2124053590
PR Review Comment: https://git.openjdk.org/jfx/pull/1820#discussion_r2124058977
More information about the openjfx-dev
mailing list