RFR: 8313424: JavaFX controls in the title bar (Preview) [v75]

[Kevin Rushforth]

On Tue, 20 May 2025 19:01:26 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> Implementation of [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
>
> Michael Strauß has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 96 commits:
> 
>  - Merge branch 'master' into feature/extended-window
>  - javadoc
>  - Merge branch 'master' into feature/extended-window
>  - reapply overlay CSS
>  - Merge branch 'master' into feature/extended-window
>  - simplify header area picking
>  - Fix top resize border on Windows
>  - Merge branch 'master' into feature/extended-window
>  - doc change
>  - add HeaderDragType
>  - ... and 86 more: https://git.openjdk.org/jfx/compare/a14c2b33...dcbb68d0

I ran this through our CI build (after merging the latest master) and I get these failures:


modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp: In member function 'virtual void WindowContextTop::show_system_menu(int, int)':
modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp:1414:39: error: invalid conversion from 'gpointer' {aka 'void*'} to 'GdkWindow*' {aka '_GdkWindow*'} [-fpermissive]
 1414 |     buttonEvent->window = g_object_ref(gdk_window);
      |                           ~~~~~~~~~~~~^~~~~~~~~~~~
      |                                       |
      |                                       gpointer {aka void*}
modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp:1415:39: error: invalid conversion from 'gpointer' {aka 'void*'} to 'GdkDevice*' {aka '_GdkDevice*'} [-fpermissive]
 1415 |     buttonEvent->device = g_object_ref(device);
      |                           ~~~~~~~~~~~~^~~~~~~~
      |                                       |
      |                                       gpointer {aka void*}

> Task :graphics:ccLinuxGlassGlassgtk3 FAILED


Our production CI systems compile against an older version of gtk3, which is likely the reason. This will need to be fixed using an explicit cast. A quick test shows that this fixes the problem.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1605#issuecomment-2936232000