RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v16]

[John Hendrikx]

On Sat, 7 Jun 2025 20:05:51 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> John Hendrikx has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Change StackOverflowException to warning log
>>  - Support keeping last message in Logging helper
>
> modules/javafx.base/src/test/java/test/javafx/beans/ObservableValueTest.java line 490:
> 
>> 488:     }
>> 489: 
>> 490:     static class Action<T> implements ObservableValue<T> {
> 
> Can be `private`. Same for `Case` and some others. Not that there's a big risk of using these classes from other places in the package, but the confinement helps the reader understand that its used specifically in this class.

I tend to leave out unnecessary modifiers in test cases to keep things more concise. Being a test case, and an inner class, I think that should be sufficient to alert the reader that it is specific for this class.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1081#discussion_r2134556112