RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v16]

[John Hendrikx]

On Sat, 7 Jun 2025 20:44:04 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> John Hendrikx has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Change StackOverflowException to warning log
>>  - Support keeping last message in Logging helper
>
> modules/javafx.base/src/test/java/test/javafx/beans/ObservableValueTest.java line 118:
> 
>> 116:     @ParameterizedTest
>> 117:     @MethodSource("inputs")
>> 118:     <T> void shouldIgnoreRemovingNonExistingListener(Action<T> action) {
> 
> Am I missing what is asserted in this test? Where is the "ignoring non-existing listeners" check being done?

I added a comment here, but as the code should "ignore" the action, I expect nothing to happen (ie. no exception).  Since tests fail if an exception **is** thrown the test does what it should do.

I've added `assertDoesNotThrow` to make it even more explicit.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1081#discussion_r2134562103