RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v16]

John Hendrikx jhendrikx at openjdk.org
Sun Jun 8 09:39:04 UTC 2025


On Sat, 7 Jun 2025 23:56:38 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> John Hendrikx has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Change StackOverflowException to warning log
>>  - Support keeping last message in Logging helper
>
> modules/javafx.base/src/test/java/test/javafx/beans/ObservableValueTest.java line 708:
> 
>> 706:             }
>> 707: 
>> 708:             int[] next = new int[] {values[x], values[(y + s) % m]};
> 
> Since the iteration is always over a pair of values, wouldn't it be more appropriate to use something like a `record ListenerNumbers(int invalidations, int changes)`? It would also make `Combinations` clearer.

I've changed it; I must have been feeling particularly frugal when I wrote this :)

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1081#discussion_r2134574625


More information about the openjfx-dev mailing list