RFR: 8334137: Marlin: replace sun.misc.Unsafe memory access methods with FFM [v4]

[Kevin Rushforth]

On Sun, 8 Jun 2025 12:37:01 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

>> Kevin Rushforth has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Request alignment when reallocating segment
>
> modules/javafx.graphics/src/main/java/com/sun/marlin/OffHeapArray.java line 53:
> 
>> 51:         arena = Arena.ofConfined();
>> 52: 
>> 53:         // note: may throw OOME:
> 
> This note is probably outdated? 
> You removed it at least below, so probably can do here as well?

It's still relevant, so I added back the comment I inadvertently removed.

> modules/javafx.graphics/src/main/java/com/sun/marlin/OffHeapArray.java line 69:
> 
>> 67:     /**
>> 68:      * Gets the length of this array.
>> 69:      *
> 
> Minor: The javadoc below has no empty line between the description and the return, so maybe remove here as well?

done

> modules/javafx.graphics/src/main/java/com/sun/marlin/OffHeapArray.java line 94:
> 
>> 92:     /**
>> 93:      * Increments the number of bytes currently being used.
>> 94:      * Curr used + incr used must be <= length
> 
> Typo? Can be named to: `Current used + increment must be <= length` maybe.

Fixed. I also changed the name of the argument to be `increment` for clarity.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1814#discussion_r2135878253
PR Review Comment: https://git.openjdk.org/jfx/pull/1814#discussion_r2135878478
PR Review Comment: https://git.openjdk.org/jfx/pull/1814#discussion_r2135879497