RFR: 8334137: Marlin: replace sun.misc.Unsafe memory access methods with FFM [v5]

[Kevin Rushforth]

On Mon, 9 Jun 2025 15:44:08 GMT, Per Minborg <pminborg at openjdk.org> wrote:

>> Kevin Rushforth has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments
>
> modules/javafx.graphics/src/main/java/com/sun/marlin/OffHeapArray.java line 47:
> 
>> 45:     /* members */
>> 46:     private MemorySegment segment;
>> 47:     private long length;
> 
> Maybe we can remove the `length` field and instead use `segment.byteSize()`?

Thanks. I've done this.

> modules/javafx.graphics/src/main/java/com/sun/marlin/OffHeapArray.java line 106:
> 
>> 104:      */
>> 105:     void resize(final long len) {
>> 106:         Arena newArena = Arena.ofConfined();
> 
> The comment "updating address is MANDATORY" can be removed.

Good catch. I've remove this and added a better description.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1814#discussion_r2136154724
PR Review Comment: https://git.openjdk.org/jfx/pull/1814#discussion_r2136155932