RFR: 8313424: JavaFX controls in the title bar (Preview) [v83]
Markus Mack
mmack at openjdk.org
Tue Jun 10 15:52:52 UTC 2025
On Tue, 10 Jun 2025 02:51:34 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:
>> Implementation of [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
>
> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>
> only dispose ViewSceneOverlay when non-null
I tested and can also confirm that the issue occurs without the latest patch, and is resolved now. Additionally I checked my own title bar test app.
When checking the controlsfx sampler app I do see CSS-related `ClassCastException`s in the "ComponentValidation" section, but they seem to be present with the current jfx master branch already.
The code changes look reasonable.
-------------
Marked as reviewed by mmack (Author).
PR Review: https://git.openjdk.org/jfx/pull/1605#pullrequestreview-2914182217
More information about the openjfx-dev
mailing list