RFR: 8313424: JavaFX controls in the title bar (Preview) [v83]

[Kevin Rushforth]

On Thu, 12 Jun 2025 19:41:47 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

> it was introduced by the previous patch. In order for CSS to work as expected, all nodes must be traceable to a single root node. This means that the parent of the overlay node is the scene root. However, in some cases during bounds calculation, the method `Parent.childBoundsChanged(Node)` is invoked on the root node by the overlay node.
> 
> `Parent` assumes that if a child calls this method and passes itself as an argument, that the supposed child must also be contained in its own children list. In the case of the overlay node, this it not the case. The fix for this bug is to check whether the supposed child is actually contained in the root's children list, before continuing with the code path which assumes that it is.

This explanation, and the fix you did, seem reasonable. I hope there aren't other places that make this same assumption.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1605#issuecomment-2968065990