RFR: 8359257: Create accessibility protocol for TabGroup component [v3]

Ambarish Rapte arapte at openjdk.org
Mon Jun 16 05:55:34 UTC 2025


On Thu, 12 Jun 2025 20:46:49 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Create implementation of the TabGroup protocol and assign it to TAB_PANE and PAGINATION roles.
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add accessible role description to the base component

LGTM

modules/javafx.graphics/src/main/native-glass/mac/a11y/AccessibleBase.m line 188:

> 186:                                               jAccessibilityAttributeValue, (jlong)@"AXChildren");
> 187:     GLASS_CHECK_EXCEPTION(env);
> 188:     return variantToID(env, jresult);

A general comment(not for this PR): There seems to be many methods with same body except change in last parameter in call to `CallLongMethod`. May be can change these methods to have a helper method.

-------------

Marked as reviewed by arapte (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1823#pullrequestreview-2930720201
PR Review Comment: https://git.openjdk.org/jfx/pull/1823#discussion_r2149100376


More information about the openjfx-dev mailing list