RFR: 8357393: RichTextArea: fails to properly save text attributes [v2]
Ziad El Midaoui
zelmidaoui at openjdk.org
Mon Jun 16 13:07:40 UTC 2025
On Thu, 29 May 2025 18:42:10 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> Fixing a bug that breaks proper saving of character attributes.
>>
>> This, unfortunately, makes a breaking change in the RichTextArea native format [0].
>>
>> ## References
>>
>> [0] https://github.com/andy-goryachev-oracle/Test/blob/main/doc/RichTextArea/RichTextArea_DataFormat_V2.md
>
> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>
> - Merge remote-tracking branch 'origin/master' into 8357393.attr.ser
> - javadoc
> - Merge remote-tracking branch 'origin/master' into 8357393.attr.ser
> - test
> - tests
> - fixed attribute serialization
LGTM. I’ve tested it on macOS, and the issue is resolved with this fix. It is working as expected.
-------------
Marked as reviewed by zelmidaoui (Author).
PR Review: https://git.openjdk.org/jfx/pull/1813#pullrequestreview-2932055457
More information about the openjfx-dev
mailing list