RFR: 8314482: TextFlow: TabStopPolicy [v2]
Andy Goryachev
angorya at openjdk.org
Wed Jun 18 18:39:37 UTC 2025
On Wed, 18 Jun 2025 18:11:17 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:
>> Hmm. OK then.
>
> This doesn't read like a proper English sentence to me. In Microsoft Word, there's a spinner control titled "Default tab stops:", which I suppose should be read as, for example: "Default tab stops every 0.5 cm".
>
> As for naming the API, I suggest something like `defaultTabWidth` or `defaultWidth` (the word "tab" doesn't need to be repeated, as it's declared in a class named `TabStopPolicy`).
Not sure if defaultTabWidth is a good choice here though, because it's not, it's actually tab stops - think of the typewriter (I know, referring to an ancient technology like floppy disk for the 'save' icon does not age well)
I am open to suggestions. I am used to "default tab stops", perhaps we could just explain it better?
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1744#discussion_r2155251249
More information about the openjfx-dev
mailing list