RFR: 8354943: [Linux] Simplify and update glass gtk backend: window sizing, positioning, and state management issues [v45]

[Thiago Milczarek Sayao]

On Sat, 21 Jun 2025 15:40:31 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use process_expose
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/gtk/GtkView.java line 103:
> 
>> 101:     private native void _uploadPixelsIntArray(long viewPtr, int[] pixels, int offset, int width, int height);
>> 102: 
>> 103:     protected native void enterFullscreenImpl(long ptr, boolean animate, boolean keepRatio, boolean hideCursor);
> 
> This seems like an unnecessary duplication of methods. Can you not just keep the existing `_enterFullscreen()` method, and return `JNI_TRUE`?

You're right - done.

> modules/javafx.graphics/src/main/native-glass/gtk/glass_general.cpp line 696:
> 
>> 694:     GdkPixbuf * ret = NULL;
>> 695: 
>> 696:      gdk_pixbuf_get_from_window (window, srcx, srcy, width, height);
> 
> The indentation is off here.

Done.

> modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp line 1630:
> 
>> 1628:     // directly to the base implementation.
>> 1629:     if (is_fullscreen() || get_frame_type() != EXTENDED || get_jwindow() == nullptr) {
>> 1630:         WindowContext::process_mouse_button(event);
> 
> Isn't the `get_frame_type() != EXTENDED` condition unnecessary here?

Removed, it's not necessary.

> modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp line 1699:
> 
>> 1697:     // Call the base implementation for client area events.
>> 1698:     if (!is_floating()
>> 1699:             || get_frame_type() != EXTENDED
> 
> `get_frame_type() != EXTENDED` probably unnecessary.

Removed, it's not necessary.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1789#discussion_r2160100648
PR Review Comment: https://git.openjdk.org/jfx/pull/1789#discussion_r2160100966
PR Review Comment: https://git.openjdk.org/jfx/pull/1789#discussion_r2160101062
PR Review Comment: https://git.openjdk.org/jfx/pull/1789#discussion_r2160101081