RFR: 8313556: Create implementation of NSAccessibilitySlider protocol [v7]
Alexander Zuev
kizune at openjdk.org
Mon Mar 3 16:58:17 UTC 2025
On Fri, 28 Feb 2025 11:43:39 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:
>> Alexander Zuev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits:
>>
>> - Add accessibilityTitleUIElement function to the base class.
>> - Merge branch 'master' into JDK-8313556
>> - Merge pull request #13 from openjdk/master
>>
>> Merge
>> - Merge pull request #12 from openjdk/master
>>
>> Merge
>> - Merge pull request #11 from openjdk/master
>>
>> Merge
>> - Merge pull request #10 from openjdk/master
>>
>> Merge
>> - Adding accessibilityMinValue and accessibilityMaxValue
>> - Merge remote-tracking branch 'origin/master' into JDK-8313556
>> - Merge pull request #7 from openjdk/master
>>
>> Merge
>> - - Added accessibilityTitle method
>> - Removed some debug output generation
>> - ... and 4 more: https://git.openjdk.org/jfx/compare/7a7854c9...09f68099
>
> modules/javafx.graphics/src/main/native-glass/mac/a11y/AccessibleBase.m line 165:
>
>> 163: GLASS_CHECK_EXCEPTION(env);
>> 164: return variantToID(env, jresult);
>> 165: }
>
> This method is same as `accessibilityLabel`. Should we change implementation to call one method from the other ?
Makes sense.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1226#discussion_r1977853670
More information about the openjfx-dev
mailing list