RFR: 8327478: Add System test to verify TextSelection issue for webkit-617.1 [v3]

Kevin Rushforth kcr at openjdk.org
Tue Mar 4 20:41:57 UTC 2025


On Tue, 4 Mar 2025 15:45:16 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Gopal Pattnaik has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Addressed Review comments
>>  - Addressed Review comments
>
> tests/system/src/test/java/test/robot/javafx/web/TextSelectionTest.java line 89:
> 
>> 87:         Util.runAndWait(() -> colorAfter = robot.getPixelColor(x, y));
>> 88: 
>> 89:         Assertions.assertNotEquals(colorBefore, colorAfter,
> 
> should we also test for non-null `colorBefore` ?

`Robot::getPixelColor` can't return null (although I checked the docs and we don't specify one way or the other). It seems fine either way.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1719#discussion_r1980191902


More information about the openjfx-dev mailing list