RFR: 8327478: Add System test to verify TextSelection issue for webkit-617.1 [v3]
Gopal Pattnaik
duke at openjdk.org
Wed Mar 5 07:09:01 UTC 2025
On Tue, 4 Mar 2025 12:14:43 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Gopal Pattnaik has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Addressed Review comments
>> - Addressed Review comments
>
> tests/system/src/test/java/test/robot/javafx/web/TextSelectionTest.java line 42:
>
>> 40: import test.util.Util;
>> 41:
>> 42: public class TextSelectionTest extends RobotTestBase{
>
> Minor: please add a space before the `{`
Done.
> tests/system/src/test/java/test/robot/javafx/web/TextSelectionTest.java line 50:
>
>> 48: <body>     some text</body>
>> 49: </html>
>> 50: """;
>
> One more minor code style issue: lines 45-50 should be intended
Done as per one suggestion on "https://docs.oracle.com/en/java/javase/18/text-blocks/index.html"
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1719#discussion_r1980816617
PR Review Comment: https://git.openjdk.org/jfx/pull/1719#discussion_r1980817935
More information about the openjfx-dev
mailing list