RFR: 8277000: Tree-/TableRowSkin: replace listener to fixedCellSize by live lookup [v5]

Kevin Rushforth kcr at openjdk.org
Thu Mar 6 22:02:06 UTC 2025


On Mon, 17 Feb 2025 22:56:56 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

>> This PR improves the `Tree-/TableRowSkin` code by doing a normal live lookup for the `fixedCellSize` instead of adding listener just to update variables(`fixedCellSizeEnabled` and `fixedCellSize`) which can otherwise be also just lookup'd without the hassle of listeners.
>> 
>> While this is mostly a cleanup, it does improve the state of the `Tree-/TableRow`, as when the `TableRowSkinBase` constructor is called, the variables are not yet set.
>> 
>> It is also consistent with the other cells, see also [JDK-8246745](https://bugs.openjdk.org/browse/JDK-8246745).
>> Helps a bit with [JDK-8185887](https://bugs.openjdk.org/browse/JDK-8185887) (https://github.com/openjdk/jfx/pull/1644), but as written above, not required as there is no (visible) effect.
>
> Marius Hanl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add as javadoc

@arapte Can you be the second reviewer?

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1645#issuecomment-2705036479


More information about the openjfx-dev mailing list