RFR: 8342565: [TestBug] StubTextLayout [v2]

Andy Goryachev angorya at openjdk.org
Thu Mar 6 23:40:05 UTC 2025


On Tue, 4 Feb 2025 08:53:31 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 19 additional commits since the last revision:
>> 
>>  - atomic boolean
>>  - Merge branch 'master' into 8342565.stub.text.layout
>>  - cleanup
>>  - better test
>>  - cleanup
>>  - more magic
>>  - magic numbers
>>  - more
>>  - add exports
>>  - stub fonts
>>  - ... and 9 more: https://git.openjdk.org/jfx/compare/6ed82938...5010278f
>
> I think this is a good change, completely utilizing that the text layout code is abstracted away for good.
> Changes look good to me so far. 
> Some tests are hard to understand the changes, but that is a preexisting problem (especially if the name of the test is just `rt_xxxx`).
> Not sure about the code style of using `S`, `M` or `L` as variable names (minor), so I will see what other reviewers say about this.

thank you @Maran23

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1667#issuecomment-2705176354


More information about the openjfx-dev mailing list